chore(ui): Guard ConfigureSSO based on active organization#8613
Conversation
🦋 Changeset detectedLatest commit: f4487f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3b44ae7 to
75c901d
Compare
6f5a23a to
d951d19
Compare
36ae016 to
6e345b0
Compare
75c901d to
64c9d22
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR gates ConfigureSSO behind the organizations environment setting by adding 'ConfigureSSO' as a caller for the enable flow, updating disabledSelfServeSSOFeature to check clerk.organization?.selfServeSSOEnabled, extending organization-related warnings to include ConfigureSSO, and modifying mountConfigureSSO to attempt enabling organizations, short-circuit when disabled, enforce a dev-time "user exists but no org" guard, and run existing feature checks afterwards. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Description
Resolves ORGS-1595
Do not allow
<ConfigureSSO />to be used if organizations are disabled or if the current organization session isn't active.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change